ref: Update to latest react, redux, and various supporting libs #228
Conversation
|
Aside the requireAuth stuff I abstracted as it will make some things easier to maintain in the future. Wasn't required for these updates. styled-components seems to be throwing warnings, so not sure if we just need to switch to emotion/similar, but thats probably an easy one |
| componentWillReceiveProps(nextProps, nextContext) { | ||
| let isRouterInContext = !!nextContext.router; | ||
| let isLocationInProps = nextProps.location !== undefined; | ||
| componentDidUpdate(prevProps) { |
There was a problem hiding this comment.
50% chance this breaks behavior, but given the router object is likely the same, the behavior might be the same
| // TODO(dcramer): make this simply call AsyncComponent instead of extend | ||
| export default class AsyncPage extends AsyncComponent { | ||
| static propTypes = { | ||
| params: PropTypes.object, | ||
| location: PropTypes.object | ||
| }; | ||
|
|
||
| componentWillMount() { |
There was a problem hiding this comment.
duplicated from AsyncComponent
dcramer
force-pushed
the
ref/update-lots-of-deps
branch
from
2a30a03 to
f6c4895
Compare
| transitionName="toast" | ||
| transitionEnter={false} | ||
| transitionLeaveTimeout={500}> | ||
| <TransitionGroup enter={false}> |
There was a problem hiding this comment.
i think this is not behaving the same as before, but i gave up after 10 minutes. it at least works mostly ok
dcramer
force-pushed
the
ref/update-lots-of-deps
branch
2 times, most recently
from
d30e411 to
95e79dc
Compare
package.json
Outdated
| "react-gravatar": "^2.6.3", | ||
| "react-icon-base": "^2.0.8", | ||
| "react-icons": "^2.2.7", | ||
| "react-loadable": "^5.3.1", | ||
| "react-redux": "^5.0.5", | ||
| "react-router": "3.2.0", | ||
| "react-redux": "5", |
There was a problem hiding this comment.
enzyme's shallow rendered doesnt work with react-redux 6+
dcramer
force-pushed
the
ref/update-lots-of-deps
branch
from
95e79dc to
ec8bd5b
Compare
dcramer
force-pushed
the
ref/update-lots-of-deps
branch
from
ec8bd5b to
e3809a6
Compare
dcramer
force-pushed
the
ref/update-lots-of-deps
branch
from
d2bc470 to
2deb6a4
Compare
|
this PR is now very much 🤞 |
dcramer
force-pushed
the
ref/update-lots-of-deps
branch
from
b22e00b to
1db34e8
Compare
dcramer
force-pushed
the
ref/update-lots-of-deps
branch
from
61b75ff to
32a25ac
Compare
No description provided.