Skip to content

Commit

Permalink
Bump version and confirm production ready
Browse files Browse the repository at this point in the history
  • Loading branch information
ryannealmes committed Jul 23, 2015
1 parent 2e1fb0a commit 39d7e07
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
7 changes: 2 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ Moodle::Api.configure({host: 'http://my_moodle_instance.com',
service: 'my_external_service', # ensure you include the shortname of the external service
username: 'jonsnow',
password: 'defendthewall'})

params = { 'criteria[0][key]' => 'firstname', 'criteria[0][value]' => 'Jon' }

Moodle::Api.core_user_get_users(params)
Expand Down Expand Up @@ -118,14 +118,11 @@ Note: regenerating vcr cassettes, some data will change which will break the tes
5. Create a new Pull Request
6. Ensure your stuff is rubocop'd

I am always keen to learn so please feel free to create an issue with code reviews, suggestions and possible refactorings.
I am always keen to learn so please feel free to create an issue with code reviews, suggestions and possible refactorings.

## TODOS

- Add additional protocols
- Make cassettes easily rerunnable - will require a parser for the response to remove dynamic data or a funky regex in the specs.
- Moodle web services require you to know how the Moodle API expects params. They are pretty messy. It would be nice to leverage hashes and arrays and then parse them to into what moodle expects.

## Warning

This gem is still under heavy development.
3 changes: 2 additions & 1 deletion lib/moodle/api/version.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
module Moodle
# Used to determine the current version of the gem
# Semantic versioning is used
# http://guides.rubygems.org/patterns/#semantic-versioning
module Api
VERSION = '1.3'
VERSION = '1.4'
end
end

0 comments on commit 39d7e07

Please sign in to comment.