Separate Buffer/Encoder for RenderPass Encoders #1300
Conversation
To avoid needing to include traits with lifetime parameters in the GraphicsCommandBuffer trait, we split the RenderPass*Encoder trait into RenderPass*Buffer (a backend-implemented trait with no lifetime parameters) and a struct RenderPass*Encoder containing the necessary lifetime parameters and associated references. These structs proxy all their calls to the Buffer trait implementations by passing a reference to the whole struct that includes the buffer as a member, as well as the lifetime-bound references. As a result the backend implementations have access to all the data they had previously without having to resort to lifetime parameters on the trait or unsafety.
|
I'll spin up Windows and fix the DX12 backend later tonight, but the Metal and Vulkan backends worked when I tested them. |
| @@ -405,8 +405,7 @@ fn main() { | |||
| cmd_buffer.bind_graphics_descriptor_sets(&pipeline_layout, 0, &[&set0[0], &set1[0]]); | |||
|
|
|||
| { | |||
| let mut encoder = back::RenderPassInlineEncoder::begin( | |||
| &mut cmd_buffer, | |||
| let mut encoder = cmd_buffer.begin_render_pass_inline( | |||
|
For dx12, our current goal should be that it compiles, |
|
On further reflection I think we might actually want to make the RenderPassBuffer traits hidden in their entirety. They never show up in any capacity unless you're writing a backend; all users see is a GraphicsCommandBuffer as a generic parameter for the RenderPassEncoder struct. The duplication of the method names could be quite confusing when reading the documentation. |
|
So we'll have multiple visibility rings, logically:
|
|
The build is only failing on nightly, from an out of memory error when compiling dxguid-sys (which appears to a known bug in rustc). |
| @@ -20,6 +20,7 @@ use winapi::*; | |||
|
|
|||
| use core::{self, command, memory, pso, state, target, IndexType, VertexCount, VertexOffset}; | |||
| use core::buffer::IndexBufferView; | |||
| use core::command::{RenderPassInlineEncoder, RenderPassSecondaryEncoder, Encoder}; | |||
There was a problem hiding this comment.
nit: command is already included, so there should be either just command or all the types we use from it for consistency
|
Thank you! |
|
📌 Commit d78585d has been approved by |
Separate Buffer/Encoder for RenderPass Encoders To avoid needing to include traits with lifetime parameters in the GraphicsCommandBuffer trait, we split the RenderPass\*Encoder trait into RenderPass\*Buffer (a backend-implemented trait with no lifetime parameters) and a struct RenderPass*Encoder containing the necessary lifetime parameters and associated references. These structs proxy all their calls to the Buffer trait implementations by passing a reference to the whole struct that includes the buffer as a member, as well as the lifetime-bound references. As a result the backend implementations have access to all the data they had previously without having to resort to lifetime parameters on the trait or unsafety.
|
☀️ Test successful - status |
To avoid needing to include traits with lifetime parameters in
the GraphicsCommandBuffer trait, we split the RenderPass*Encoder trait
into RenderPass*Buffer (a backend-implemented trait with no lifetime
parameters) and a struct RenderPass*Encoder containing the necessary
lifetime parameters and associated references.
These structs proxy all their calls to the Buffer trait implementations
by passing a reference to the whole struct that includes the buffer as
a member, as well as the lifetime-bound references. As a result the
backend implementations have access to all the data they had previously
without having to resort to lifetime parameters on the trait or
unsafety.