Parameterise Renderer over Device and rename CommandBufferHelper #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamnemecek
pushed a commit
to adamnemecek/gfx
that referenced
this pull request
Apr 1, 2021
1159: Zero initialize buffers r=kvark a=Wumpf **Connections** First half of gfx-rs#563, focusing solely on buffers and ignoring same issue for textures **Description** Tracks for each buffer which parts are initialized (i.e. set to zero). Identified three interaction points for this: * buffer mapping: Zeroing out ad-hoc and marking as initialized * queue write to buffer: Marks target buffer regions as initialized (i.e. optimizes away buffer init down the line) * use in binding or copy operation in a command buffer: * fine grained tracking of regions that may require init (or will be initialized implicitly) on each command buffer * set in motion on queue submit, init is exclusively with `fill_buffer` Todo list for Ready-to-Review - [x] memory barriers for `fill_buffer` calls - [x] better data structure for `memory_init_tracker` - [x] coarse filtering on command-buffer buffer init requirements (the list should almost always be empty whereas now it pushes any buffer use) - [x] improve naming of things - [x] at least pretend this is adequately tested Todo list beyond this PR * make data structures usable for textures * and.. well.. implement all this for textures! * explore reusing barrier tracker for memory init tracking? **Testing** * Some basic testing by doing some changes to wgpu-rs samples and watching them in in the debugger. * Added a ron test file for the player (love those!) to poke the feature a little bit * MemoryInitTracker comes with simple unit tests Overall this is a bit shallow but as so often in this area accurate testing is hard because the outcomes are quite indirect Co-authored-by: Andreas Reich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renderercontains handles that will be associated onDevicein the future when we implement #416.