Make device::gl_device crate fully self-contained #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -49,8 +49,8 @@ fn test_vertex_format() { | |||
| use secret_lib::gfx; | |||
| use secret_lib::device; | |||
|
|
|||
| let buf_vert = device::make_fake_buffer(); | |||
| let buf_inst = device::make_fake_buffer(); | |||
| let buf_vert = device::gl_device::make_dummy_buffer(); | |||
There was a problem hiding this comment.
I'd like these tests to be device-agnostic. We'll clean it up later.
kvark
added a commit
that referenced
this pull request
Feb 23, 2015
Make device::gl_device crate fully self-contained
|
👍 🎉 |
|
\o/ party! |
|
🎈 |
|
🎈 🎉 |
adamnemecek
pushed a commit
to adamnemecek/gfx
that referenced
this pull request
Apr 1, 2021
598: Enable READ access for texture storage r=kvark a=kvark This is a short-term workaround until we properly implement gfx-rs#597 Co-authored-by: Dzmitry Malyshau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #416.
Sorry for flip-flopping on the type parameter of
Renderer- I previously changed it beforeGlResourceswas a 'thing'.