This repository has been archived by the owner on Jan 29, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 193
[glsl-out] Return type for returning arrays is incorrect #2380
Labels
area: back-end
Outputs of shader conversion
kind: bug
Something isn't working
lang: GLSL
OpenGL Shading Language
Comments
Wumpf
changed the title
[glsl-out] Return type for returning arrays is incorrect.
[glsl-out] Return type for returning arrays is incorrect
Jun 13, 2023
This was referenced Jun 13, 2023
Wumpf
added a commit
to rerun-io/rerun
that referenced
this issue
Jun 13, 2023
<!-- Open the PR up as a draft until you feel it is ready for a proper review. Do not make PR:s from your own `main` branch, as that makes it difficult for reviewers to add their own fixes. Add any improvements to the branch as new commits to make it easier for reviewers to follow the progress. All commits will be squashed to a single commit once the PR is merged into `main`. Make sure you mention any issues that this PR closes in the description, as well as any other related issues. To get an auto-generated PR description you can put "copilot:summary" or "copilot:walkthrough" anywhere. --> ### What Works around gfx-rs/naga#2380 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2413 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/26e3636/docs Examples preview: https://rerun.io/preview/26e3636/examples <!-- pr-link-docs:end -->
Linking a similar HLSL issue: gfx-rs/wgpu#4393 |
teoxoy
added
kind: bug
Something isn't working
area: back-end
Outputs of shader conversion
lang: GLSL
OpenGL Shading Language
labels
Jun 13, 2023
emilk
pushed a commit
to rerun-io/rerun
that referenced
this issue
Jun 15, 2023
<!-- Open the PR up as a draft until you feel it is ready for a proper review. Do not make PR:s from your own `main` branch, as that makes it difficult for reviewers to add their own fixes. Add any improvements to the branch as new commits to make it easier for reviewers to follow the progress. All commits will be squashed to a single commit once the PR is merged into `main`. Make sure you mention any issues that this PR closes in the description, as well as any other related issues. To get an auto-generated PR description you can put "copilot:summary" or "copilot:walkthrough" anywhere. --> ### What Works around gfx-rs/naga#2380 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2413 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/26e3636/docs Examples preview: https://rerun.io/preview/26e3636/examples <!-- pr-link-docs:end -->
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area: back-end
Outputs of shader conversion
kind: bug
Something isn't working
lang: GLSL
OpenGL Shading Language
To my understanding wgsl supports having arrays as return types. However, the glsl backend doesn't handle this correctly right now, putting the element type as return value:
Minimal repro:
Wgsl in:
Glsl out (
cargo run --all-features -- ./test.wgsl test.frag
):The text was updated successfully, but these errors were encountered: