Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single-recording mode for passes #89

Closed
kvark opened this issue Mar 3, 2019 · 1 comment
Closed

Single-recording mode for passes #89

kvark opened this issue Mar 3, 2019 · 1 comment
Labels
type: enhancement New feature or request

Comments

@kvark
Copy link
Member

kvark commented Mar 3, 2019

Currently, we are hitting a problem with DX12 backend whenever we use render passes: it doesn't support more than a single command buffer in a recording state at a time per command pool. We keep the root command buffer open while the pass command buffer is recorded, so that we can append necessary resource transitions at the end of that root command buffer.

We need a mode, in which we'd be closing the root command buffer, then recording the pass command buffer, and only afterwards record an additional command buffer for transitions. Not sure if that one will even be needed in general case, since:

  1. metal backend doesn't need transitions
  2. dx12 backend has implicit conversion to/from general state

Note: the problem currently results in validation warnings, but will turn into a crash with gfx-rs/gfx#2667
@kvark kvark added the type: enhancement New feature or request label Mar 3, 2019
@kvark kvark mentioned this issue Jan 7, 2020
Closed
mitchmindtree pushed a commit to mitchmindtree/wgpu that referenced this issue Feb 23, 2020
@bors
Merge gfx-rs#89
697393d 
89: Adapter::get_info r=kvark a=paulkernfeld

This more or less addresses gfx-rs#7.

If the example is too trivial, I'm happy to remove it.

Co-authored-by: Paul Kernfeld <[email protected]>
kvark pushed a commit to kvark/wgpu that referenced this issue Jun 3, 2021
@bors
[rs] Merge gfx-rs#89
05f5447 
89: Adapter::get_info r=kvark a=paulkernfeld

This more or less addresses gfx-rs#7.

If the example is too trivial, I'm happy to remove it.

Co-authored-by: Paul Kernfeld <[email protected]>
@cwfitzgerald
Copy link
Member

CLosed via the new hal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kvark @cwfitzgerald