Refactor usage tracking to be truly sparse #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
changed the title
kvark
changed the title
|
Tested on wgpu-rs examples as well as vange-rs. Fairly confident that this is ready to merge. |
|
As outlined in #438 (comment), this isn't moving us to the goal, strictly speaking. I still believe it's a good change to land though. |
Merged
|
Merging as a dependency for #440 |
bors bot
added a commit
that referenced
this pull request
Jan 9, 2020
439: Refactor usage tracking to be truly sparse r=dependency a=kvark ~~This is a required step towards #438 . We want to be tracking the usage by only having resource IDs around, not resources themselves. So we aren't going to have access to `full_selector`.~~ It's also streamlining some of the verbose parts of the internal API for usage tracking. It also uses `SmallVec` for the texture tracker ranges, essentially making it lightweight for most cases (where the layer count is 1). Compromises: - removes `SEPARATE_DEPTH_STENCIL_STATES` support. It's not in the near future to enable it anyway. Co-authored-by: Dzmitry Malyshau <[email protected]>
Build succeeded |
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
439: Update to latest `wgpu-core` r=kvark a=GabrielMajeri Pull in some of the latest changes from the `wgpu` repo Co-authored-by: Gabriel Majeri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a required step towards #438 . We want to be tracking the usage by only having resource IDs around, not resources themselves. So we aren't going to have access tofull_selector.It's also streamlining some of the verbose parts of the internal API for usage tracking.
It also uses
SmallVecfor the texture tracker ranges, essentially making it lightweight for most cases (where the layer count is 1).Compromises:
SEPARATE_DEPTH_STENCIL_STATESsupport. It's not in the near future to enable it anyway.