Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out ComputeCommand id->arc resolve (a step towards no lifetimes on wgpu::ComputePass) #5432

Merged
merged 15 commits into from
Apr 23, 2024
Merged

Separate out ComputeCommand id->arc resolve (a step towards no lifetimes on wgpu::ComputePass) #5432

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
620ee44
move out compute command to separate module
Wumpf Mar 23, 2024
21019f1
introduce ArcComputeCommand
Wumpf Mar 23, 2024
3ef5497
stateless tracker now returns reference to arc upon insertion
Wumpf Mar 23, 2024
2d3d1c5
add insert_merge_single to buffer tracker
Wumpf Mar 23, 2024
9745c83
compute pass execution now works internally with an ArcComputeCommand
Wumpf Mar 23, 2024
1d93fa4
compute pass execution now translates Command to ArcCommand ahead of …
Wumpf Mar 24, 2024
ee1878e
Merge branch 'trunk' into separate-computepass-arc-resolve
Wumpf Apr 4, 2024
e0d9c12
Merge branch 'trunk' into separate-computepass-arc-resolve
Wumpf Apr 6, 2024
9867e9d
Merge branch 'trunk' into separate-computepass-arc-resolve
Wumpf Apr 18, 2024
708890b
don't clone commands in compute pass execution
Wumpf Apr 20, 2024
23bb7f5
remove doc hiding
Wumpf Apr 20, 2024
2ed66d3
use option insert
Wumpf Apr 20, 2024
659d74b
clippy fix
Wumpf Apr 20, 2024
0eea8c5
fix private doc issue
Wumpf Apr 20, 2024
66d45e3
remove unnecessary copied over doc hide
Wumpf Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion player/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ impl GlobalPlay for wgc::global::Global {
base,
timestamp_writes,
} => {
self.command_encoder_run_compute_pass_impl::<A>(
self.command_encoder_run_compute_pass_with_unresolved_commands::<A>(
encoder,
base.as_ref(),
timestamp_writes.as_ref(),
Expand Down
Loading
Loading