Fix missing wgt re-export on wgpu for CopyExternalImageDestInfo
#6962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
the
PR: needs back-porting
|
since wgt is not re-exported anywhere this is actually pretty bad. Forces users (me in this case ;)) to depend on wgt directly :/ |
Wumpf
added a commit
to rerun-io/rerun
that referenced
this pull request
Jan 20, 2025
teoxoy
approved these changes
Jan 20, 2025
|
You won't believe it, but this is something I also done in https://github.com/gfx-rs/wgpu/pull/6658/files#diff-69eb2a0461b18b418449129eaf12c15ee0a277bbaebb6860f2711de5fd6aa06a, I should split off minor changes more into separate PRs so they do not get blocked on big stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a missing export from
wgpuTesting
Use that type through
wgpu's re-export (really, everything should imho)Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.