-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update requirements to latest versions, update Docker, and include CI/CD publish #144
Conversation
…lude CI/CD publish * Moved from patch-level locks to minimum version checks (ensuring compatibility until major changes break things) * Removed Splinters overrides of browsers - light touch behaving so it should work with newer versions * Added automatic PyPI version publishing via GitHub (once PyPI OIDC trust to repo is established) * Introduced flake8 for code linting * Updated GitHub `ci.yml` to use the latest versions
Hi @ggozad , For .github/workflows/publish.yml to work. Please visit https://pypi.org/manage/project/behaving/settings/publishing/ and add GitHub Publishing Owner: Then you should be able to push a new version (like 3.2.0) and it should auto publish for you. You can see a trial deployment here: https://github.com/duttonw/behaving/actions/runs/12593771887/job/35100362897 which is not authorised for your pypi project. This is based off https://github.com/ckan/ckanext-validation/blob/master/.github/workflows/publish.yml but instead of duplicating test steps, i referenced your ci.yml workflow and if that passes, then continue. Plus ensured that publish is skipped for non pypi owners. |
@ThrawnCA can you give this a lookover. |
browser_name = "INTERNETEXPLORER" | ||
|
||
# Collect correct Options class for Selenium based on browser. | ||
if browser_name in ("CHROME", "ELECTRON", "REMOTE"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Electron is now handled here in wrapping.
Hey William, |
We use this extension in our BDD testing of CKAN via our Qld Government org https://github.com/qld-gov-au/. I've recently uplifted profanityfilter which also needed a secondary maintainer due to lack of time. I don't mind being added as a maintainer to keep it patched. My username on pypi is: duttonwz |
Done! You should now be a maintainer/collaborator here as well as on pypi. |
Hi @ggozad , Sadly for OIDC GitHub publishing, only Owner's can set it up. Can you complete this last step. Regards, |
Once that is completed. Then rerun job https://github.com/ggozad/behaving/actions/runs/12615567035/job/35155832534 |
Thanks for completing the setup @ggozad. The latest version is auto deployed :). no more needing a local pc to do it. yay :) |
ci.yml
to use the latest versionsbump to 3.2.0 (but could be higher since the webdriver overrides have been removed)
fixes: #143