Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update requirements to latest versions, update Docker, and include CI/CD publish #144

Merged
merged 3 commits into from
Jan 5, 2025

Conversation

duttonw
Copy link
Collaborator

@duttonw duttonw commented Jan 3, 2025

  • Moved from patch-level locks to minimum version checks (ensuring compatibility until major changes break things)
  • Removed Splinters overrides of browsers
    • light touch behaving so it should work with newer versions
  • Added automatic PyPI version publishing via GitHub (once PyPI OIDC trust to repo is established)
  • Introduced flake8 for code linting
  • Updated GitHub ci.yml to use the latest versions

bump to 3.2.0 (but could be higher since the webdriver overrides have been removed)

fixes: #143

…lude CI/CD publish

* Moved from patch-level locks to minimum version checks (ensuring compatibility until major changes break things)
* Removed Splinters overrides of browsers
  - light touch behaving so it should work with newer versions
* Added automatic PyPI version publishing via GitHub (once PyPI OIDC trust to repo is established)
* Introduced flake8 for code linting
* Updated GitHub `ci.yml` to use the latest versions
@duttonw
Copy link
Collaborator Author

duttonw commented Jan 3, 2025

Hi @ggozad ,

For .github/workflows/publish.yml to work.

Please visit https://pypi.org/manage/project/behaving/settings/publishing/ and add GitHub Publishing

Owner: ggozad
Repository name: behaving
Workflow name: publish.yml
Environment name (optional): pypi

Then you should be able to push a new version (like 3.2.0) and it should auto publish for you.

You can see a trial deployment here: https://github.com/duttonw/behaving/actions/runs/12593771887/job/35100362897 which is not authorised for your pypi project.

This is based off https://github.com/ckan/ckanext-validation/blob/master/.github/workflows/publish.yml but instead of duplicating test steps, i referenced your ci.yml workflow and if that passes, then continue.

Plus ensured that publish is skipped for non pypi owners.

@duttonw
Copy link
Collaborator Author

duttonw commented Jan 3, 2025

@ThrawnCA can you give this a lookover.

browser_name = "INTERNETEXPLORER"

# Collect correct Options class for Selenium based on browser.
if browser_name in ("CHROME", "ELECTRON", "REMOTE"):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Electron is now handled here in wrapping.

@ggozad
Copy link
Owner

ggozad commented Jan 3, 2025

Hey William,
Thanks for this. I have been considering either obsoleting behaving or getting a new maintainer.
I do not currently have the time to dedicate to it. Let me have a think about this during the weekend and I will get back to you asap.

@duttonw
Copy link
Collaborator Author

duttonw commented Jan 3, 2025

We use this extension in our BDD testing of CKAN via our Qld Government org https://github.com/qld-gov-au/.

I've recently uplifted profanityfilter which also needed a secondary maintainer due to lack of time.

I don't mind being added as a maintainer to keep it patched. My username on pypi is: duttonwz

@ggozad
Copy link
Owner

ggozad commented Jan 4, 2025

Done! You should now be a maintainer/collaborator here as well as on pypi.

@duttonw
Copy link
Collaborator Author

duttonw commented Jan 4, 2025

@duttonw duttonw self-assigned this Jan 4, 2025
@duttonw duttonw added enhancement dependencies Pull requests that update a dependency file labels Jan 4, 2025
@duttonw duttonw merged commit 4b4dc62 into ggozad:main Jan 5, 2025
@duttonw
Copy link
Collaborator Author

duttonw commented Jan 5, 2025

@duttonw
Copy link
Collaborator Author

duttonw commented Jan 6, 2025

Thanks for completing the setup @ggozad. The latest version is auto deployed :). no more needing a local pc to do it. yay :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Splinter version to support newer Selenium
2 participants