Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update emodnet-chemistry.mustache #10

Closed
wants to merge 1 commit into from

Conversation

meliezer
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 81.436% when pulling 7185227 on meliezer:patch-3 into efbc0a1 on gher-ulg:master.

@codecov-io
Copy link

codecov-io commented Aug 20, 2018

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #10   +/-   ##
=======================================
  Coverage   81.85%   81.85%           
=======================================
  Files          78       78           
  Lines        4261     4261           
=======================================
  Hits         3488     3488           
  Misses        773      773

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efbc0a1...7185227. Read the comment docs.

@Alexander-Barth
Copy link
Member

It has been a deliberate choice to make the DIVA product unrestricted as opposed to "SeaDataNet licensed". Why are you making this change?

@meliezer
Copy link
Contributor Author

I wasn't aware of this choice. Please keep it as unrestricted.

@Alexander-Barth
Copy link
Member

Alexander-Barth commented Aug 21, 2018

All the text that you changed come initial from Ifremer.
I suppose that you checked with them that the changes are OK. Can you make a new pull request with the unrestricted license?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants