Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xterm audit: DECALN, Top/Bot Margins, Left/Right Margins #646

Merged
merged 4 commits into from
Oct 10, 2023
Merged

Conversation

mitchellh
Copy link
Contributor

  • Tests for set top/bottom margins
  • Fix issue where set top/bottom margins should do NOTHING if top >= bot
  • DECALN should reset margins
  • DECALN should reset origin mode
  • Implement mode 69 (enable left/right margins)
  • Implement DECSLRM (set left and right margins)

NOTE: Ghostty will responds as if it doesn't know what mode 69 is, so it is still impossible for running applications to actually set left/right margins. The core plumbing is there however and we just need to flip a bit to turn it on. I am waiting to turn it on until I finish auditing more sequences to ensure left/right margins work properly.

@mitchellh mitchellh mentioned this pull request Oct 10, 2023
@mitchellh mitchellh merged commit 04756e1 into main Oct 10, 2023
@mitchellh mitchellh deleted the sm branch October 10, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant