Skip to content
This repository has been archived by the owner on Jan 15, 2020. It is now read-only.

Set SilenceUsage to true in root command #6

Merged
merged 1 commit into from
Apr 9, 2019
Merged

Set SilenceUsage to true in root command #6

merged 1 commit into from
Apr 9, 2019

Conversation

rossf7
Copy link
Contributor

@rossf7 rossf7 commented Apr 9, 2019

Follow up for #3 (comment)

I found spf13/cobra#340 which suggests setting SilenceUsage to true on the root command. It doesn't output the usage message when an error occurs.

@rossf7 rossf7 self-assigned this Apr 9, 2019
@rossf7 rossf7 requested a review from a team April 9, 2019 14:35
kopiczko
kopiczko approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@kopiczko kopiczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Will you propagate the changes to devctl command as well?

@rossf7
Copy link
Contributor Author

rossf7 commented Apr 9, 2019

@kopiczko Yes sure I'll update devctl.

@rossf7 rossf7 merged commit 0a640c5 into master Apr 9, 2019
@rossf7 rossf7 deleted the silence-usage branch April 9, 2019 14:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MarcelMue MarcelMue MarcelMue approved these changes

@kopiczko kopiczko kopiczko approved these changes

@xh3b4sd xh3b4sd xh3b4sd approved these changes

Assignees

@rossf7 rossf7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rossf7 @xh3b4sd @kopiczko @MarcelMue