Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E.164 extensions #255

Closed
kiler129 opened this issue Jun 7, 2018 · 4 comments
Closed

E.164 extensions #255

kiler129 opened this issue Jun 7, 2018 · 4 comments
Labels

Comments

@kiler129
Copy link

kiler129 commented Jun 7, 2018

Today I discovered that \libphonenumber\PhoneNumberUtil::format() doesn't handle extensions at all in case of E.164. I was used to see extensions in form of phone;ext=123, however the library doesn't do such thing.

Is this by design or do we have a bug here?

@giggsey
Copy link
Owner

giggsey commented Jun 7, 2018

See #152.

E164 shouldn't contain any extension information. This PHP project matches Google's implementation.

@kiler129
Copy link
Author

kiler129 commented Jun 7, 2018

@giggsey Yes... I just checked Google's Java implementation and indeed they do the same. I'm thinking if there's any sanestandard way to save extension along with extension?

@giggsey
Copy link
Owner

giggsey commented Jun 7, 2018

I'm not sure to be honest.

As you mentioned in misd-service-development/phone-number-bundle#183, serialisation could work, but that's quite a large storage increase over E164.

This might be better suited for Google's mailing list in case there is a general format to use for this situation.

@giggsey
Copy link
Owner

giggsey commented Jun 24, 2018

I'm going to close this issue, as it isn't a problem with this PHP port itself.

If Google update their API, this project will be updated to match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants