-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E.164 extensions #255
Comments
See #152. E164 shouldn't contain any extension information. This PHP project matches Google's implementation. |
@giggsey Yes... I just checked Google's Java implementation and indeed they do the same. I'm thinking if there's any |
I'm not sure to be honest. As you mentioned in misd-service-development/phone-number-bundle#183, serialisation could work, but that's quite a large storage increase over E164. This might be better suited for Google's mailing list in case there is a general format to use for this situation. |
I'm going to close this issue, as it isn't a problem with this PHP port itself. If Google update their API, this project will be updated to match. |
Today I discovered that
\libphonenumber\PhoneNumberUtil::format()
doesn't handle extensions at all in case of E.164. I was used to see extensions in form ofphone;ext=123
, however the library doesn't do such thing.Is this by design or do we have a bug here?
The text was updated successfully, but these errors were encountered: