Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E164 should not include extension number #152

Closed
RubenKruiswijk opened this issue Jan 9, 2017 · 2 comments
Closed

E164 should not include extension number #152

RubenKruiswijk opened this issue Jan 9, 2017 · 2 comments
Assignees
@giggsey
Labels
bug

Comments

@RubenKruiswijk
Copy link

I've found a discrepancy between the original libphonenumber implementation and this one regarding the handling of the extension for the E164 format.

https://libphonenumber.appspot.com/phonenumberparser?number=%2B1-907-486-4171+ex.+101&country=US&geocodingLocale=en-US
E164: +19074864171

https://giggsey.com/libphonenumber/index.php?phonenumber=%2B1-907-486-4171+ext.+101&country=US&language=en&region=US
E164: +19074864171 ext. 101
@giggsey giggsey added the bug label Jan 9, 2017
@giggsey giggsey self-assigned this Jan 9, 2017
giggsey added a commit that referenced this issue Jan 9, 2017
@giggsey
Fix E164 formatting so it doesn't return extensions
4658ca2 
Now matches Google's Java implementation

Fixes #152
@giggsey giggsey mentioned this issue Jan 9, 2017
Merged
@giggsey
Copy link
Owner

giggsey commented Jan 9, 2017

Thanks for reporting.

It looks like this bug has existed since 2012/2013.

Once Google release their next version (I believe they are aiming for this week), then a new version will be tagged here. The Release Notes will mention this change, as some people might be relying on formatting to E164 to output extensions.

@RubenKruiswijk
Copy link
Author

Boss! Thanks!

@giggsey giggsey mentioned this issue Jun 7, 2018
Closed
@merk merk mentioned this issue Jun 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giggsey giggsey

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@giggsey @RubenKruiswijk