Improve WebDAV performance #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This pull request has been mentioned on Duplicacy Forum. There might be relevant details there: https://forum.duplicacy.com/t/error-too-many-open-files/3155/33 |
|
Thank you for the fixes. This seems to fix https://forum.duplicacy.com/t/error-too-many-open-files/3155 -- I should have merged this much earlier... |
|
This pull request has been mentioned on Duplicacy Forum. There might be relevant details there: https://forum.duplicacy.com/t/cli-2-7-0-is-now-available/4260/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
io.Copy(ioutil.Discard, resp.Body), which is needed for proper connection reuse, as described here: https://awmanoj.github.io/tech/2016/12/16/keep-alive-http-requests-in-golang/The current code performs as follows for me:
And with this PR, it looks like this:
Please forgive any stupid mistakes I might have made. This is quite literally my first time doing anything in go.