periodically save check progress to verified_chunks #662
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added code that periodically saves the list of verified chunks. This addresses the following feature request: https://forum.duplicacy.com/t/feature-request-periodically-write-the-list-of-verified-chunks/8014
For this, I have spawned a goroutine that calls
saveVerifiedChunks()
once every hour. The goroutine automatically terminated when all chunkIDs have been written tochunkChannel
and thus at mostthreads
chunks remain for verification.Future improvements could add functionality that allows users to specify the interval at which the progress is saved through command-line parameters, however, I think that 1 hour is reasonable as writing to disks costs almost no resources.
I'd be grateful for feedback regarding this PR and hopefully getting this merged. In any case, thank you @gilbertchen for creating duplicacy!
Please excuse the formatting changes that have been performed automatically by my editor.