Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No documentation / source code #47

Closed
erikhuizinga opened this issue Dec 21, 2018 · 1 comment
Closed

No documentation / source code #47

erikhuizinga opened this issue Dec 21, 2018 · 1 comment

Comments

@erikhuizinga
Copy link
Contributor

erikhuizinga commented Dec 21, 2018 •
edited
Loading

I see no documentation nor sources in Android Studio (3.2.1), just the compiled .class files. Maybe the wrong artifacts are being uploaded to whatever online repo?

I looked into the Gradle cache (where the JARs are stored) and it does include the sources.jar file, but it is empty:

$ jar -tf ~/.gradle/caches/modules-2/files-2.1/ru.gildor.coroutines/kotlin-coroutines-retrofit/1.0.0/3380d25eb4f4e54022fbe59ba7261a9d05780177/kotlin-coroutines-retrofit-1.0.0-sources.jar

META-INF/
META-INF/MANIFEST.MF
ru/
ru/gildor/
ru/gildor/coroutines/
ru/gildor/coroutines/retrofit/

These are all the files in the JAR: just directories, no files.

It seems there's something wrong with your source artifact packaging!
@erikhuizinga
Copy link
Contributor Author

I've made a fix, opening a PR in a minute.

@erikhuizinga erikhuizinga mentioned this issue Dec 21, 2018
Merged
gildor added a commit that referenced this issue Feb 11, 2019
@gildor
Version 1.1.0
28f656b 
- [Retrofit 2.5.0](https://github.com/square/retrofit/blob/parent-2.5.0/CHANGELOG.md#version-250-2018-11-18)
- [kotlinx.coroutines 1.1.1](https://github.com/Kotlin/kotlinx.coroutines/releases/tag/1.1.1)
- Compiled against Kotlin 1.3.21
- Fixed javadoc and source code jars. Thanks to @erikhuizinga for contribution #47
- Gradle 5.2.1
- Update publishing config to new DSL
@gildor gildor mentioned this issue Feb 11, 2019
Merged
gildor added a commit that referenced this issue Feb 11, 2019
@gildor
Version 1.1.0 (#49)
95430e7 
- [Retrofit 2.5.0](https://github.com/square/retrofit/blob/parent-2.5.0/CHANGELOG.md#version-250-2018-11-18)
- [kotlinx.coroutines 1.1.1](https://github.com/Kotlin/kotlinx.coroutines/releases/tag/1.1.1)
- Compiled against Kotlin 1.3.21
- Fixed javadoc and source code jars. Thanks to @erikhuizinga for contribution #47
- Gradle 5.2.1
- Update publishing config to new DSL
gildor added a commit that referenced this issue Feb 11, 2019
@gildor
Version 1.1.0
fb72051 
- [Retrofit 2.5.0](https://github.com/square/retrofit/blob/parent-2.5.0/CHANGELOG.md#version-250-2018-11-18)
- [kotlinx.coroutines 1.1.1](https://github.com/Kotlin/kotlinx.coroutines/releases/tag/1.1.1)
- Compiled against Kotlin 1.3.21
- Fixed javadoc and source code jars. Thanks to @erikhuizinga for contribution #47
- Gradle 5.2.1
- Update publishing config to new DSL
gildor added a commit that referenced this issue Feb 11, 2019
@gildor
Version 1.1.0 (#49)
80abaa2 
- [Retrofit 2.5.0](https://github.com/square/retrofit/blob/parent-2.5.0/CHANGELOG.md#version-250-2018-11-18)
- [kotlinx.coroutines 1.1.1](https://github.com/Kotlin/kotlinx.coroutines/releases/tag/1.1.1)
- Compiled against Kotlin 1.3.21
- Fixed javadoc and source code jars. Thanks to @erikhuizinga for contribution #47
- Gradle 5.2.1
- Update publishing config to new DSL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erikhuizinga