Switch addr2line to use EndianReader. #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @philipc, this diff on my binary is crashing at |
philipc
reviewed
Apr 22, 2021
|
Sweet that worked! I can confirm memory usage drops 3x & is now better than llvm-symbolizer. Runtime is similarly ~3x faster. |
|
Hmm... some weird test failures I'm unable to reproduce locally (running Arch) |
|
CI works. Probably it's the output equivalence test, which depends on the binutils version, since we are comparing our output with it. |
philipc
requested changes
Apr 23, 2021
vlovich
force-pushed
the
zero-copy-addr2line
branch
from
b62f16b to
377dc0f
Compare
Avoid copying the debug into RAM & instead use borrows to utilize the 0-copy facility of gimli.
vlovich
force-pushed
the
zero-copy-addr2line
branch
from
377dc0f to
e83963e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid copying the debug into RAM & instead use borrows to utilize the 0-copy facility of gimli.
Resolves #212