Store boxed slices instead of Vec objects in Context
#278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We never resize the unit ranges, units, or sup units that we parsed -- they stay what they were when we instantiated the Context object. As such, we don't need to store Vec objects, which include a capacity. Do what we do for the Functions type and just store boxed slices. Doing so cuts a machine word of each, but also trims heap allocations to the minimal size required in the process. Signed-off-by: Daniel Müller <[email protected]>
|
If capacity and size don't match trimming is expensive as it requires a copy of all data in many cases. |
|
None of the benchmarks show any significant difference, so seems fine to me. Is this patch due to something you noticed in use, or only from code review? |
It's from code review. If you don't like it then feel free to close, no hard feelings. But to me trimming in most places but not in others seems bogus, given that we are not modifying these structures afterwards by design. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We never resize the unit ranges, units, or sup units that we parsed -- they stay what they were when we instantiated the Context object. As such, we don't need to store
Vecobjects, which include a capacity. Do what we do for theFunctionstype and just store boxed slices. Doing so cuts a machine word of each, but also trims heap allocations to the minimal size required in the process.