gin-gonic · appleboy · Oct 26, 2021 · Aug 29, 2021 · Aug 29, 2021 · Aug 30, 2021
diff --git a/routes_test.go b/routes_test.go
@@ -621,3 +621,24 @@ func TestRouteContextHoldsFullPath(t *testing.T) {
 	w := performRequest(router, http.MethodGet, "/not-found")
 	assert.Equal(t, http.StatusNotFound, w.Code)
 }
+
+// Reproduction test for the bug of issue #2843
+func TestRouteTrailingSlashRoute(t *testing.T) {
 func TestRouterNotFound(t *testing.T) { 
 	router := New() 
 	router.RedirectFixedPath = true 
 	router.GET("/path", func(c *Context) {}) 
 	router.GET("/dir/", func(c *Context) {}) 
 	router.GET("/", func(c *Context) {}) 
 	testRoutes := []struct { 
 		route    string 
 		code     int 
 		location string 
 	}{ 
 		{"/path/", http.StatusMovedPermanently, "/path"},   // TSR -/ 
 		{"/dir", http.StatusMovedPermanently, "/dir/"},     // TSR +/ 
 		{"/PATH", http.StatusMovedPermanently, "/path"},    // Fixed Case 
 		{"/DIR/", http.StatusMovedPermanently, "/dir/"},    // Fixed Case 
 		{"/PATH/", http.StatusMovedPermanently, "/path"},   // Fixed Case -/ 
 		{"/DIR", http.StatusMovedPermanently, "/dir/"},     // Fixed Case +/ 
 		{"/../path", http.StatusMovedPermanently, "/path"}, // Without CleanPath 
 		{"/nope", http.StatusNotFound, ""},                 // NotFound 
 	} 
 	for _, tr := range testRoutes { 
 		w := performRequest(router, http.MethodGet, tr.route) 
 		assert.Equal(t, tr.code, w.Code) 
 		if w.Code != http.StatusNotFound { 
 			assert.Equal(t, tr.location, fmt.Sprint(w.Header().Get("Location"))) 
 		} 
 	} 
 	// Test custom not found handler 
 	var notFound bool 
 	router.NoRoute(func(c *Context) { 
 		c.AbortWithStatus(http.StatusNotFound) 
 		notFound = true 
 	}) 
 	w := performRequest(router, http.MethodGet, "/nope") 
 	assert.Equal(t, http.StatusNotFound, w.Code) 
 func TestRouterNotFound(t *testing.T) { 
 	router := New() 
 	router.RedirectFixedPath = true 
 	router.GET("/path", func(c *Context) {}) 
 	router.GET("/dir/", func(c *Context) {}) 
 	router.GET("/", func(c *Context) {}) 
  
 	testRoutes := []struct { 
 		route    string 
 		code     int 
 		location string 
 	}{ 
 		{"/path/", http.StatusMovedPermanently, "/path"},   // TSR -/ 
 		{"/dir", http.StatusMovedPermanently, "/dir/"},     // TSR +/ 
 		{"/PATH", http.StatusMovedPermanently, "/path"},    // Fixed Case 
 		{"/DIR/", http.StatusMovedPermanently, "/dir/"},    // Fixed Case 
 		{"/PATH/", http.StatusMovedPermanently, "/path"},   // Fixed Case -/ 
 		{"/DIR", http.StatusMovedPermanently, "/dir/"},     // Fixed Case +/ 
 		{"/../path", http.StatusMovedPermanently, "/path"}, // Without CleanPath 
 		{"/nope", http.StatusNotFound, ""},                 // NotFound 
 	} 
 	for _, tr := range testRoutes { 
 		w := performRequest(router, http.MethodGet, tr.route) 
 		assert.Equal(t, tr.code, w.Code) 
 		if w.Code != http.StatusNotFound { 
 			assert.Equal(t, tr.location, fmt.Sprint(w.Header().Get("Location"))) 
 		} 
 	} 
  
 	// Test custom not found handler 
 	var notFound bool 
 	router.NoRoute(func(c *Context) { 
 		c.AbortWithStatus(http.StatusNotFound) 
 		notFound = true 
 	}) 
 	w := performRequest(router, http.MethodGet, "/nope") 
 	assert.Equal(t, http.StatusNotFound, w.Code) 
+	router := New()
+
+	router.NoRoute(func(c *Context) {
+		if c.Request.RequestURI == "/login" {
+			c.String(200, "login")
+		}
+	})
+
+	router.GET("/logout", func(c *Context) {
+		c.String(200, "logout")
+	})
+
+	w := performRequest(router, http.MethodGet, "/login")
+	assert.Equal(t, "login", w.Body.String())
+
+	w = performRequest(router, http.MethodGet, "/logout")
+	assert.Equal(t, "logout", w.Body.String())
+}
diff --git a/tree.go b/tree.go
@@ -599,7 +599,7 @@ walk: // Outer loop for walking the tree
 		// Nothing found. We can recommend to redirect to the same URL with an
 		// extra trailing slash if a leaf exists for that path
 		value.tsr = path == "/" ||
-			(len(prefix) == len(path)+1 && n.handlers != nil)
+			(len(prefix) == len(path)+1 && path == prefix[:len(prefix) - 1] && n.handlers != nil)
 		return
 	}
 }