Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The UP_DOWN_ARROW shape appears to have duplicate keys. #253

Closed
heavysixer opened this issue Dec 4, 2017 · 1 comment
Closed

The UP_DOWN_ARROW shape appears to have duplicate keys. #253

heavysixer opened this issue Dec 4, 2017 · 1 comment
Assignees
@gitbrent
Labels
issue:bug
Milestone
2.0.0

Comments

@heavysixer
Copy link

PptxGenJS/dist/pptxgen.shapes.js

Lines 1340 to 1341 in 6eb3649

'adj1': 50000,
'adj2': 50000,

@gitbrent gitbrent self-assigned this Dec 5, 2017
@gitbrent gitbrent added this to the 2.0.0 milestone Dec 5, 2017
gitbrent pushed a commit that referenced this issue Dec 5, 2017
Fix for Issue #253
0e2a248
@gitbrent
Copy link
Owner

gitbrent commented Dec 5, 2017

Hi @heavysixer,

Thanks for reporting this.

I checked the original file in the officegen project, and this issue has been fixed there, so i've copied it here as well.

https://github.com/Ziv-Barber/officegen/blob/5f96506471a395bf810ce52f75ae509fb22591a6/lib/pptxshapes.js#L1346-L1347

@gitbrent gitbrent changed the title These appear to duplicate keys. The UP_DOWN_ARROW shape appears to have duplicate keys. Dec 5, 2017
gitbrent pushed a commit that referenced this issue Dec 5, 2017
Added Issue #253
cf16572
@gitbrent gitbrent closed this as completed Dec 5, 2017
ericrockey pushed a commit to WeTransfer/PptxGenJS that referenced this issue Mar 24, 2020
Fix for Issue gitbrent#253
bb166ae
ericrockey pushed a commit to WeTransfer/PptxGenJS that referenced this issue Mar 24, 2020
Added Issue gitbrent#253
31469df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gitbrent gitbrent

Labels
issue:bug
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@heavysixer @gitbrent