Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add w and h attributes to page number #336

Closed
s7726 opened this issue May 15, 2018 · 1 comment
Closed

Add w and h attributes to page number #336

s7726 opened this issue May 15, 2018 · 1 comment
Assignees
Milestone

Comments

@s7726
Copy link

s7726 commented May 15, 2018

My OCD kicked in when all the slide numbers were statically sized to flow off the slide.

+ ' <a:xfrm><a:off x="'+ getSmartParseNumber(slideObject.slideNumberObj.x, 'X') +'" y="'+ getSmartParseNumber(slideObject.slideNumberObj.y, 'Y') +'"/><a:ext cx="800000" cy="300000"/></a:xfrm>'

The following change (sorry not in a spot to do a proper pull request right now) adds w and h to the slide number options.

					+ '    <a:xfrm><a:off x="'+ getSmartParseNumber(slideObject.slideNumberObj.x, 'X') +'" y="'+ getSmartParseNumber(slideObject.slideNumberObj.y, 'Y') +'"/>'
					+ '    <a:ext cx="'+ getSmartParseNumber(slideObject.slideNumberObj.w, 'X') +'" cy="'+ getSmartParseNumber(slideObject.slideNumberObj.h, 'Y') +'"/></a:xfrm>'
@gitbrent gitbrent self-assigned this May 16, 2018
@gitbrent gitbrent added this to the 2.2.0 milestone May 18, 2018
gitbrent pushed a commit that referenced this issue May 18, 2018
@gitbrent
Copy link
Owner

Hi @s7726,

Thanks for your contribution!

gitbrent pushed a commit that referenced this issue May 18, 2018
ericrockey pushed a commit to WeTransfer/PptxGenJS that referenced this issue Mar 24, 2020
ericrockey pushed a commit to WeTransfer/PptxGenJS that referenced this issue Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants