Vertical align and line break bug since update

[IntermateMedia]

Hey there,

since the last update options like valign, align and margin don't work anymore for a text element with multiple styles like here:

slide.addText( [ { text: 'Lorem', options: { bold: true, breakLine: true } }, { text: description } ], { x: 0, y: 0, w: 2, h: 2, valign: 'middle', margin: 0 } )

Valign, align and margin will be default this way.

[ZouhaierSebri]

Hi @gitbrent ,

why line 1503 and 1504 commented.
when we remove comment we get the expected result.

[IntermateMedia]

@ZouhaierSebri do you mean this one? It makes the valign work again 👍
Any idea how do fix the margin as well?

[ZouhaierSebri]

Hi @mirkoint ,
yes but we can ask @gitbrent why those lines are commented.

`textObj.options.bodyProp = ( textObj.options.bodyProp || {} );

textObj.options.bodyProp.anchor = ( textObj.options.valign || slideObj.options.valign );`

[IntermateMedia]

But it only vixes the valign. I'm also trying to fix the margin. Any idea @ZouhaierSebri ?

[IntermateMedia]

Hey @gitbrent,
when do you think this bug will be fixed? :)
Cheers,
Mirko

[Szymon-dziewonski]

yes I'm signing in to this question too :) where it will be fixed ?

Thanks

[gitbrent]

Hi @mirkoint @ZouhaierSebri @Szymon-dziewonski ,

Initially, I was vexed by this as having more than 1 align tag in a paragraph was causing issues in PowerPoint 2007, so i was hesitant and didn't to trade one issue for another. After spending months on Charts, i'm glad you all reminded me to re-engage on this one.

Turns out it was just a good old fashioned bug where i was placing a properties tag inside the wrong XML parent tag and it was getting tangled up. I've fixed in the current codebase - both valign and margin behave as intended.

Try it out now and let me know what you think. Example below.

var pptx = new PptxGenJS();
var slide = pptx.addNewSlide();

slide.addText(
  [
    { text:'Text from', options:{ bold:true, breakLine:true } },
    { text:'Issue #79' }
  ],
  { x:0, y:0, w:2, h:2, valign:'middle', margin:0, line:'0088CC', fill:'F1F1F1' }
);

pptx.save('PptxGenJS-Issue79');

[Szymon-dziewonski]

Hello @gitbrent , Thank you for respond, by the way great job, is there any way to donate you few "bucks"? :)
It's working, thanks !!

[IntermateMedia]

Awesome @gitbrent, thank you so much!

[gitbrent]

@Szymon-dziewonski - thanks!

If you want to support the project, put a link to the GitHub site on your social network. :-)