Isolate variables to the local scope #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitbrent
approved these changes
May 9, 2018
|
Hi @edvinasbartkus, Thanks for patch! These were vestiges of old method parameters and weren't rescoped after they were removed. |
ericrockey
pushed a commit
to WeTransfer/PptxGenJS
that referenced
this pull request
Mar 24, 2020
Isolate variables to the local scope
ericrockey
pushed a commit
to WeTransfer/PptxGenJS
that referenced
this pull request
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With my lab testing I get the following error:
The following leaks were detected:intPosX, intPosY, intWidth, intHeight, objHyperlink, strImageData, strImagePathSeems like after the change the variables should be isolated for the local scope.
OLD:
: addImageDefinition: function addImageDefinition(strImagePath, intPosX, intPosY, intWidth, intHeight, strImageData, target) {NEW:
: addImageDefinition: function addImageDefinition(objImage, target) {How can I make this PR acceptable for merge and new version release?