-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#228 Placeholder object for Master Slides #359
Conversation
- Added new `placeholder` type to master slides objects - Updated example/demo page to use new API - Refactored some reused code Closes gitbrent#228
Hi @conbow Thanks for the patch. The placeholder master slide's appear fine, but when adding other text to them, it's pushed to the very bottom and stuck into what looks like the last master slide's object - the footer bar in this case:
Without including My merged, WIP branch is: |
@gitbrent Thanks for catching this. There was a missing condition that allowed the |
Thanks @conbow - great work on adding support for This was a feature that was much requested and sorely lacking. Patch #393 implements this feature. The only change I made was to utilize
|
@gitbrent Could you give an example of using image with corp, as placeholder? My mistake, I was using pptxgen 2.2.0
After I upgrade to 2.4.0, it works fine. |
#228
placeholder
type to master slides objects