Add types key to package.json #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the latest Typescript, I couldn't get the Typescript compiler or VS Code to recognize that the `pptxgenjs` library had a typings file. Adding this `types` key [seems to be required](https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html) if the `*.d.ts` file isn't at the root of the project. Thanks for maintaining this project!
|
I didn't see this existed and created another PR for the same thing. Any news on this? |
|
Looks like it was merged to the version-3.0 / typescript branch on June 13: https://github.com/gitbrent/PptxGenJS/commits/version-3.0 |
|
I'd merged #558 into the head branch a few weeks ago. However, it added "typings" and that's deprecated as of Typescript 2.0 from what i've read. I'll merge this and remove the previous PR. |
gitbrent
approved these changes
Jul 3, 2019
|
Thanks @adamlong5 ! |
ericrockey
pushed a commit
to WeTransfer/PptxGenJS
that referenced
this pull request
Mar 24, 2020
Add types key to package.json
ericrockey
pushed a commit
to WeTransfer/PptxGenJS
that referenced
this pull request
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the latest Typescript, I couldn't get the Typescript compiler or VS Code to recognize that the
pptxgenjslibrary had a typings file.Adding this
typeskey seems to be required if the*.d.tsfile isn't at the root of the project.Thanks for maintaining this project!