Server Side Grants Transaction Validator #6318

owocki · 2020-03-27T18:10:19Z

Validator 1

I would like a python script written that I can pass in a list of transactions, token amounts, and token names, and it can return a 1 or a 0 for each txn to tell me if those tokens were transfered as part of that txn

Note that Gitcoin has a tool that does this already, but we're having some problems with false negatives and with replaced transactions. So I'm interested in seeing how a bounty hunter would handle this issue so we can perhaps integrate it.

example input: https://gist.github.com/owocki/179186552ec7e4c036918c5195949a25

example output

success, reason
True
True
False - tx failed
False - amount was off by 0.001

Acceptance Criteria:

No more than 1% false negatives
Should handle dropped/replaced txns

Please submit a PR that can validate token transfers (both ETH and ERC20 tokens) by Sunday night to participate in this bounty.

Validator 2

I would like some python functions that I can pass in an ethereum mainnet account and a erc20-style contract address, and it can tell me where the tokens came from.

ie.

if account minted the token, then it returns 0x0
if account received the tokens from 0xabc it returns 0xabc
if account received the tokens from 0xabc and 0xabc2 it returns [0xabc, 0xabc2]

The text was updated successfully, but these errors were encountered:

gitcoinbot · 2020-03-27T18:17:54Z

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 2.0 ETH (272.86 USD @ $136.43/ETH) attached to it.

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
Want to chip in? Add your own contribution here.
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$78,989.18 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot · 2020-03-27T18:52:43Z

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 2 weeks from now.
Please review their action plans below:

1) developerfred has been approved to start work.

Great interesting challenge I would like to work on improving this algorithm.

Learn more on the Gitcoin Issue Details page.

owocki · 2020-03-27T19:05:32Z

@developerfred can u get a PR togehter by sunday u think?

developerfred · 2020-03-27T19:09:50Z

@developerfred can u get a PR togehter by sunday u think?

I believe so, I have already structured a mind map for this quest, I will focus on scalability and agility.

erib3 · 2020-03-28T11:42:04Z

@owocki What's the amount_minus_gitcoin_fee for?

owocki · 2020-03-28T14:34:26Z

@developerfred mind submitting a WIP PR? im keen to track the progress here..

@erib3 if the gitcoin fee was charged, then the amount on chain will be amount_minus_gitcoin_fee not amount, so its provided just to make vlaidation of amounts easier for whomever is wrtiing the validator

erib3 · 2020-03-28T22:57:06Z

@owocki thanks, to handle replaced transactions is it just find transaction with same nonce? I think we might need the 'From' address to handle dropped and replaced transactions

gitcoinbot · 2020-03-29T19:48:10Z

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 2.0 ETH (255.87 USD @ $127.94/ETH) has been submitted by:

@developerfred

@owocki please take a look at the submitted work:

PR by @developerfred

Learn more on the Gitcoin Issue Details page
Want to chip in? Add your own contribution here.
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$85,202.36 more funded OSS Work available on the Gitcoin Issue Explorer

owocki · 2020-03-30T02:52:49Z

I think we might need the 'From' address to handle dropped and replaced transactions

shoot. yeah youre right. either that or use the blockscout API to handle it. if i generate you another export with from adresses in it, can you update your script to handle them?

inspireme6 · 2020-03-30T03:17:04Z

@owocki there are cases like this one:

0x64ced12ccfd17e1d965ae22eb1a1ad4bdcbc70997ebb67445285ba2258d9ce1f 0.050000000000000000 0.05 0x6B175474E89094C44Da98b954EedeAC495271d0F

where eth was transferred instead of DAI, this kind of tx should be put as failed or success?

erib3 · 2020-03-30T03:50:26Z

@owocki I could update my code, also I don't see how we could use blockscout API for this. So I think we need a new upload with 'from' address and also the 'nonce' for faster lookups

inspireme6 · 2020-03-30T05:32:30Z

I just noticed the token transactions are Approval methods not the real transfer.

0x4216da9b2e848d592d63c8a4d6b57d3aa77dfc63c074182d093ddc35b5a1c5cb 6.900000000000000000 6.555000000000001 0x6B175474E89094C44Da98b954EedeAC495271d0F

e.g this tx approves 1000 DAI to be spended but only 6.9 was actually transferred, this could be misleading i think.

not ideal but scraping the grants addresses could be more accurate and will most likely fix both the false negatives and replaced txs issues.

owocki · 2020-03-30T13:24:14Z

where eth was transferred instead of DAI, this kind of tx should be put as failed or success?

definitely failed, but with a comment explaining why.

I could update my code, also I don't see how we could use blockscout API for this.

someone told me the blockscout API can give you the replacement tx_id.

I just noticed the token transactions are Approval methods not the real transfer.

if i provide a combo of txid1 and txid2, of which one must be the transfer of the actual tokens, would that work? there are cases in which we receive 2 txns from the frontend but only the second will transfer funds.

owocki · 2020-03-30T14:20:22Z

here is some new input data that includes txid1 and txid2, but also the from address (so we can find dropped and replaced txns) https://gist.github.com/owocki/a298bad096288754d55d61e87b385eac

- add token symbol

inspireme6 · 2020-04-01T05:26:49Z

Let me know if #6349 is kind of a good approach or definitely no.

owocki · 2020-04-01T15:42:57Z

@inspireme6 thanks for doing that, but @developerfred is working on the bounty so i def have to continue on the track with him. just an FYI RE: the bounty funds. maybe if we fold some of your approach in i can pay ya both out since the result will be better!

inspireme6 · 2020-04-01T17:25:39Z

@owocki that sounds okay to me! I wish there was a better way to tackle the issue with the dropped/replaced tx. I still had fun :)

owocki · 2020-04-01T21:51:27Z

old ticket => #5762

gitcoinbot · 2020-04-13T11:22:48Z

⚡️ A tip worth 2.50000 ETH (382.87 USD @ $153.15/ETH) has been granted to @developerfred for this issue from @owocki. ⚡️

Nice work @developerfred! Your tip has automatically been deposited in the ETH address we have on file.

$100883.49 in Funded OSS Work Available at: https://gitcoin.co/explorer
Incentivize contributions to your repo: Send a Tip or Fund a PR
No Email? Get help on the Gitcoin Slack

gitcoinbot · 2020-04-13T11:22:56Z

⚡️ A tip worth 0.50000 ETH (76.57 USD @ $153.15/ETH) has been granted to @inspireme6 for this issue from @owocki. ⚡️

Nice work @inspireme6! Your tip has automatically been deposited in the ETH address we have on file.

$100883.49 in Funded OSS Work Available at: https://gitcoin.co/explorer
Incentivize contributions to your repo: Send a Tip or Fund a PR
No Email? Get help on the Gitcoin Slack

gitcoinbot · 2020-04-13T12:46:04Z

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This Bounty has been completed.

Additional Tips for this Bounty:

owocki tipped 0.5000 ETH worth 76.6 USD to inspireme6.
owocki tipped 2.5000 ETH worth 382.99 USD to developerfred.

Learn more on the Gitcoin Issue Details page
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$100,562.76 more funded OSS Work available on the Gitcoin Issue Explorer

inspireme6 · 2020-04-13T17:16:14Z

Thanks @owocki @developerfred

owocki changed the title ~~Grant Transaction Validator~~ Server Side Grants Transaction Validator Mar 27, 2020

developerfred mentioned this issue Mar 29, 2020

feat: grants_transaction_validator #6331

Closed

erib3 mentioned this issue Mar 30, 2020

script to check transactions #6332

Closed

developerfred added a commit to developerfred/web that referenced this issue Mar 30, 2020

[done] ERC20 Transactions check and human readable value gitcoinco#6318

de1f0ed

developerfred added a commit to developerfred/web that referenced this issue Mar 30, 2020

[done] ERC20 Transactions check and human readable value gitcoinco#6318

aa41d4a

- add token symbol

developerfred added a commit to developerfred/web that referenced this issue Mar 30, 2020

[done] ERC20 Transactions check and human readable value gitcoinco#6318

c178854

- add token symbol

inspireme6 mentioned this issue Apr 1, 2020

test script to do grants tx validation #6349

Closed

developerfred added a commit to developerfred/web that referenced this issue Apr 1, 2020

add getReplacedTX(tx) gitcoinco#6318 gitcoinco#6349

e8bced5

developerfred added a commit to developerfred/web that referenced this issue Apr 1, 2020

add getReplacedTX(tx) gitcoinco#6318 gitcoinco#6349

877cb7d

owocki added the grants_round_6 label Jun 5, 2020

owocki mentioned this issue Jun 5, 2020

I was listed as contributor, without paying anything. #6779

Closed

owocki added a commit that referenced this issue Jun 11, 2020

https://github.com/gitcoinco/web/issues/6318

bffc696

owocki mentioned this issue Jun 11, 2020

validate grants contributions better #6825

Closed

thelostone-mc closed this as completed Dec 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Server Side Grants Transaction Validator #6318

Server Side Grants Transaction Validator #6318

owocki commented Mar 27, 2020 •

edited

Loading

gitcoinbot commented Mar 27, 2020

gitcoinbot commented Mar 27, 2020 •

edited

Loading

owocki commented Mar 27, 2020

developerfred commented Mar 27, 2020

erib3 commented Mar 28, 2020 •

edited

Loading

owocki commented Mar 28, 2020

erib3 commented Mar 28, 2020 •

edited

Loading

gitcoinbot commented Mar 29, 2020

owocki commented Mar 30, 2020

inspireme6 commented Mar 30, 2020

erib3 commented Mar 30, 2020 •

edited

Loading

inspireme6 commented Mar 30, 2020 •

edited

Loading

owocki commented Mar 30, 2020

owocki commented Mar 30, 2020

inspireme6 commented Apr 1, 2020

owocki commented Apr 1, 2020

inspireme6 commented Apr 1, 2020

owocki commented Apr 1, 2020

gitcoinbot commented Apr 13, 2020

gitcoinbot commented Apr 13, 2020

gitcoinbot commented Apr 13, 2020

inspireme6 commented Apr 13, 2020

Server Side Grants Transaction Validator #6318

Server Side Grants Transaction Validator #6318

Comments

owocki commented Mar 27, 2020 • edited Loading

Validator 1

Validator 2

gitcoinbot commented Mar 27, 2020

gitcoinbot commented Mar 27, 2020 • edited Loading

owocki commented Mar 27, 2020

developerfred commented Mar 27, 2020

erib3 commented Mar 28, 2020 • edited Loading

owocki commented Mar 28, 2020

erib3 commented Mar 28, 2020 • edited Loading

gitcoinbot commented Mar 29, 2020

owocki commented Mar 30, 2020

inspireme6 commented Mar 30, 2020

erib3 commented Mar 30, 2020 • edited Loading

inspireme6 commented Mar 30, 2020 • edited Loading

owocki commented Mar 30, 2020

owocki commented Mar 30, 2020

inspireme6 commented Apr 1, 2020

owocki commented Apr 1, 2020

inspireme6 commented Apr 1, 2020

owocki commented Apr 1, 2020

gitcoinbot commented Apr 13, 2020

gitcoinbot commented Apr 13, 2020

gitcoinbot commented Apr 13, 2020

inspireme6 commented Apr 13, 2020

owocki commented Mar 27, 2020 •

edited

Loading

gitcoinbot commented Mar 27, 2020 •

edited

Loading

erib3 commented Mar 28, 2020 •

edited

Loading

erib3 commented Mar 28, 2020 •

edited

Loading

erib3 commented Mar 30, 2020 •

edited

Loading

inspireme6 commented Mar 30, 2020 •

edited

Loading