Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stringify json logging to be single line #168

Merged
merged 1 commit into from
Jun 12, 2024
Merged

fix: stringify json logging to be single line #168

merged 1 commit into from
Jun 12, 2024

Conversation

ajhenry
Copy link
Contributor

@ajhenry ajhenry commented Jun 12, 2024 •
edited
Loading

Pull Request

Proposed Changes

console.log makes object appear on multiple lines. This adds support for a single line to be picked up by json by using stringify

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run npm run lint and fix any linting issues that have been introduced
  • run npm run test and run tests
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, maintenance, or breaking

@ajhenry ajhenry requested a review from a team as a code owner June 12, 2024 17:37
@github-actions github-actions bot added the fix label Jun 12, 2024
jmeridth
jmeridth approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@jmeridth jmeridth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

centralized and clean. so nice.

@ajhenry ajhenry added the bug Something isn't working label Jun 12, 2024
@ajhenry ajhenry merged commit e5dcd38 into main Jun 12, 2024
15 checks passed
@ajhenry ajhenry deleted the ajhenry/stringify branch June 12, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sutterj sutterj sutterj approved these changes

@jmeridth jmeridth jmeridth approved these changes

Assignees
No one assigned
Labels
bug Something isn't working fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajhenry @jmeridth @sutterj