Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: edit mirror dialog to display current mirror name #178

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

zkoppert
Copy link
Contributor

@zkoppert zkoppert commented Jun 13, 2024

Pull Request

fixes #136

Proposed Changes

Updates the 'Edit mirror' dialog to display the current mirror name instead of the placeholder text 'repository-name'.

  • Changes the initial state of newMirrorName to use the mirrorName prop, ensuring the current mirror name is displayed when the dialog opens.
  • Updates the placeholder in the TextInput component to display the current mirror name, enhancing user experience by showing relevant information.
  • Adjusts the logic for resetting newMirrorName upon dialog actions (cancel, confirm, close) to revert to the current mirror name instead of the placeholder, maintaining consistency with the initial state change.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run npm run lint and fix any linting issues that have been introduced
  • run npm run test and run tests
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, maintenance, or breaking

@github-actions github-actions bot added the fix label Jun 13, 2024
@zkoppert zkoppert changed the title Fix: edit mirror dialog to display current mirror name fix: edit mirror dialog to display current mirror name Jun 13, 2024
@zkoppert
Copy link
Contributor Author

zkoppert commented Jun 13, 2024

I believe we can but wanted to check: Can we safely assume that the mirrorName is never empty? Otherwise, this would result in the placeholder being blank.

@zkoppert zkoppert marked this pull request as ready for review June 13, 2024 18:52
@zkoppert zkoppert requested a review from a team as a code owner June 13, 2024 18:52
@zkoppert
Copy link
Contributor Author

Anyone have local dev setup working so they could check this looks correct in the running app? Otherwise I can work to get that setup going this afternoon.

@sutterj
Copy link
Contributor

sutterj commented Jun 13, 2024

I'll check it out here locally now.

@sutterj
Copy link
Contributor

sutterj commented Jun 13, 2024

Current mirror name is missing from location:

Screenshot 2024-06-13 at 3 13 37 PM

@sutterj
Copy link
Contributor

sutterj commented Jun 13, 2024

Screenshot 2024-06-13 at 3 33 20 PM Screenshot 2024-06-13 at 3 33 24 PM

@zkoppert
Copy link
Contributor Author

Thanks for the find and fix @sutterj!

@zkoppert zkoppert merged commit 22a0ee6 into main Jun 13, 2024
12 checks passed
@zkoppert zkoppert deleted the fix-edit-dialog branch June 13, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The 'edit mirror' dialog should present the current name of the mirror instead of the sample text
2 participants