Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

fix: missing rename icon #1046

Merged

Conversation

thegiantbeast
Copy link

Fixes #1037

Had to rename the icon name since the term "rename" was used everywhere in the code and it just seemed that the filename didn't follow that logic.

This will make the code work since the icon is now the expected name and not "moved" as before.

@thegiantbeast
Copy link
Author

@shana / @StanleyGoldman ? can you check this small PR? thank you.

@FurkanKambay
Copy link

FurkanKambay commented Apr 19, 2019

<EmbeddedResource Include="IconsAndLogos\moved%402x.png" />
<EmbeddedResource Include="IconsAndLogos\moved.png" />

<EmbeddedResource Include="IconsAndLogos\moved%402x.png" />
<EmbeddedResource Include="IconsAndLogos\moved.png" />

@thegiantbeast
Copy link
Author

Thank you @FurkanKambay for pointing out my failed build error.

I've fixed it and it should be good to go now.

@shana
Copy link
Member

shana commented May 21, 2019

Oh wow jeez, how was this ever working o.O
So sorry for the delay in dealing with this, we've been trying to figure out maintenance of this project going forward so things have been a bit blocked. I'll get this in and get a new release going, thank you for taking the time to fix it!

@shana shana merged commit f8f1b64 into github-for-unity:master May 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not find a part of the path
3 participants