Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix section number reference #37

Closed
wants to merge 2 commits into from
Closed

Fix section number reference #37

wants to merge 2 commits into from

Conversation

jessla
Copy link
Contributor

@jessla jessla commented Mar 21, 2017

In Section 2 there's a reference to the "section above" but it refers to that section as Section 2 when it seems like it should be Section 1. From a quick glance the .pdf version also has this error.

@mlinksva
Copy link
Collaborator

@jessla thanks, you're right! How embarrassing. This is my fault, introduced in #33.

I wish we could get rid of the numbered reference altogether as it feels like it makes the text slightly more fragile for reuse, but that's just a wish. I'll plan on updating version and adding generated PDF and other documents to branch in a bit, then merging.

@mlinksva
Copy link
Collaborator

FYI I haven't merged this yet because I've noticed a couple other potential non-substantive copyedits that may be worth doing before bumping to v1.0.1.

make lists in owns/doesn't sections identical
remove repetitive/redundant "above"
@mlinksva
Copy link
Collaborator

Closing, commits incorporated into #44

@mlinksva mlinksva closed this May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants