Fix processing errors being caught and logged as a warning rather tha…

…n failing the workflow run.

CHANGELOG.md

@@ -2,7 +2,7 @@
 
 ## [UNRELEASED]
 
-No user facing changes.
+- When `wait-for-processing` is enabled, the workflow will now fail if there were any errors that occurred during processing of the analysis results.
 
 ## 2.1.9 - 27 Apr 2022
 

src/upload-lib.ts

@@ -15,6 +15,7 @@ import { parseRepositoryNwo, RepositoryNwo } from "./repository";
 import * as sharedEnv from "./shared-environment";
 import * as util from "./util";
 import { SarifFile } from "./util";
+import { OctokitResponse } from "@octokit/types";
 
 // Takes a list of paths to sarif files and combines them together,
 // returning the contents of the combined sarif file.
@@ -471,31 +472,34 @@ export async function waitForProcessing(
       );
       break;
     }
+    let response: OctokitResponse<any> | undefined = undefined;
     try {
-      const response = await client.request(
+      response = await client.request(
         "GET /repos/:owner/:repo/code-scanning/sarifs/:sarif_id",
         {
           owner: repositoryNwo.owner,
           repo: repositoryNwo.repo,
           sarif_id: sarifID,
         }
       );
-      const status = response.data.processing_status;
-      logger.info(`Analysis upload status is ${status}.`);
-      if (status === "complete") {
-        break;
-      } else if (status === "pending") {
-        logger.debug("Analysis processing is still pending...");
-      } else if (status === "failed") {
-        throw new Error(
-          `Code Scanning could not process the submitted SARIF file:\n${response.data.errors}`
-        );
-      }
     } catch (e) {
       logger.warning(
         `An error occurred checking the status of the delivery. ${e} It should still be processed in the background, but errors that occur during processing may not be reported.`
       );
+      break;
     }
+    const status = response.data.processing_status;
+    logger.info(`Analysis upload status is ${status}.`);
+    if (status === "complete") {
+      break;
+    } else if (status === "pending") {
+      logger.debug("Analysis processing is still pending...");
+    } else if (status === "failed") {
+      throw new Error(
+        `Code Scanning could not process the submitted SARIF file:\n${response.data.errors}`
+      );
+    }
+
     await util.delay(STATUS_CHECK_FREQUENCY_MILLISECONDS);
   }
   logger.endGroup();