Address comments

CHANGELOG.md

@@ -6,7 +6,7 @@ Note that the only difference between `v2` and `v3` of the CodeQL Action is the
 
 ## [UNRELEASED]
 
-No user facing changes.
+- Experimental: add a new `start-proxy` action which starts the same HTTP proxy as used by [`github/dependabot-action`](https://github.com/github/dependabot-action). Do not use this in production as it is part of an internal experiment and subject to change at any time.
 
 ## 3.25.11 - 28 Jun 2024
 

src/start-proxy-action-post.ts

@@ -7,6 +7,8 @@ import * as fs from "fs";
 
 import * as core from "@actions/core";
 
+import * as actionsUtil from "./actions-util";
+import * as configUtils from "./config-utils";
 import { wrapError } from "./util";
 
 async function runWrapper() {
@@ -20,7 +22,12 @@ async function runWrapper() {
       `start-proxy post-action step failed: ${wrapError(error).message}`,
     );
   }
-  if (core.isDebug()) {
+  const config = await configUtils.getConfig(
+    actionsUtil.getTemporaryDirectory(),
+    core,
+  );
+
+  if ((config && config.debugMode) || core.isDebug()) {
     const logFilePath = core.getState("proxy-log-file");
     if (logFilePath) {
       const readStream = fs.createReadStream(logFilePath);

src/start-proxy-action.ts

@@ -42,7 +42,7 @@ const CERT_SUBJECT = [
   },
   {
     name: "organizationName",
-    value: "GitHub ic.",
+    value: "GitHub inc.",
   },
   {
     shortName: "OU",
@@ -130,6 +130,7 @@ async function runWrapper() {
       });
       subprocess.on("exit", (code) => {
         if (code !== 0) {
+          // If the proxy failed to start, try a different port from the ephemeral range [49152, 65535]
           port = Math.floor(Math.random() * (65535 - 49152) + 49152);
           subprocess = undefined;
         }

start-proxy/action.yml

@@ -1,5 +1,5 @@
 name: "CodeQL: Start proxy"
-description: "Start HTTP proxy server"
+description: "[Experimental] Start HTTP proxy server"
 author: "GitHub"
 inputs:
   registry_secrets: