Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
aeisenberg authored Feb 9, 2023
1 parent e75245f commit 999f341
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 0 additions & 3 deletions src/config-utils.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2504,9 +2504,6 @@ test("no generateRegistries when CLI is too old", async (t) => {
undefined,
"'registries' input is not supported on CodeQL versions less than 2.10.4."
);

// t.is(registriesAuthTokens, undefined);
// t.is(qlconfigFile, undefined);
});
});
test("no generateRegistries when registries is undefined", async (t) => {
Expand Down
3 changes: 2 additions & 1 deletion src/init.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,8 @@ export async function runInit(

try {
if (await codeQlVersionAbove(codeql, CODEQL_VERSION_NEW_TRACING)) {
// Only create the qlconfig file if we haven't already created it.
// When parsing the codeql config in the CLI, we have not yet created the qlconfig file.
// So, create it now.
// If we are parsing the config file in the Action, then we already created the qlconfig
// file in `configUtils.generateRegistries`.
let registriesAuthTokens: string | undefined;
Expand Down

0 comments on commit 999f341

Please sign in to comment.