Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Unset tracing variables after finalizing databases.
The tracer is very good at preserving itself, so unsetting the tracing-specific variables from within a process will not end tracing for children of that process. The way the actions process model works means that we're running inside a process for the entire build step that was launched with the tracer variables set, so we'll have the tracer injected into the entire build step and its children. If we unset the variables in end-tracing, we will get into an intermediate state: Not all variables in there are preserved by the tracer, but the tracer is still active. Usually, that wouldn't be a problem, but the autobuilders called from the finalize step will suddenly run under a half-configured tracer. Particularly, this half-configured tracer is unable to execute the dotnet CLI without hangs, as the environment variable that prevents hangs for dotnet on MacOS has been unset, but the tracer is still active. This is an issue for the the go autobuilder, that invokes user-provided build scripts in the hope of installing dependencies. If that build script then invokes dotnet, it will hang. This is only of concern for the Lua tracer that now implements proper multi-language tracing: Previously, when encountering the go autobuilder, the tracer disabled itself entirely, thus side-stepping any hangs. In the new, multi-language tracing world, the tracer will stay active as long as there is at least one other language that's been set up for tracing. Thus, we also get hangs when invoking the dotnet CLI through the go autobuilder.
- Loading branch information