Fix writing diagnostics on Windows

Remove colons from the generated filename so it is valid on Windows.
github · Aug 19, 2024 · e5a6587 · e5a6587
1 parent 5c681ef
commit e5a6587
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/lib/diagnostics.js b/lib/diagnostics.js
diff --git a/lib/diagnostics.js.map b/lib/diagnostics.js.map
diff --git a/src/diagnostics.ts b/src/diagnostics.ts
@@ -145,7 +145,8 @@ function writeDiagnostic(
 
     const jsonPath = path.resolve(
       diagnosticsPath,
-      `codeql-action-${diagnostic.timestamp}.json`,
+      // Remove colons from the timestamp as these are not allowed in Windows filenames.
+      `codeql-action-${diagnostic.timestamp.replaceAll(":", "")}.json`,
     );
 
     writeFileSync(jsonPath, JSON.stringify(diagnostic));