Don't use Zstandard bundles on Windows

In testing, gzip performs better than Zstandard on Windows.
github · Oct 10, 2024 · eefb943 · eefb943
1 parent 9d1e406
commit eefb943
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 8 deletions.
diff --git a/.github/workflows/__zstd-bundle-fallback.yml b/.github/workflows/__zstd-bundle-fallback.yml
diff --git a/.github/workflows/__zstd-bundle.yml b/.github/workflows/__zstd-bundle.yml
diff --git a/lib/setup-codeql.js b/lib/setup-codeql.js
diff --git a/lib/setup-codeql.js.map b/lib/setup-codeql.js.map
diff --git a/pr-checks/checks/zstd-bundle-fallback.yml b/pr-checks/checks/zstd-bundle-fallback.yml
@@ -4,7 +4,6 @@ versions:
   - linked
 operatingSystems:
   - macos
-  - windows
   - ubuntu
 env:
   CODEQL_ACTION_ZSTD_BUNDLE: true

diff --git a/pr-checks/checks/zstd-bundle.yml b/pr-checks/checks/zstd-bundle.yml
@@ -4,7 +4,6 @@ versions:
   - linked
 operatingSystems:
   - macos
-  - windows
   - ubuntu
 env:
   CODEQL_ACTION_ZSTD_BUNDLE: true

diff --git a/src/setup-codeql.ts b/src/setup-codeql.ts
@@ -823,6 +823,8 @@ async function useZstdBundle(
   tarSupportsZstd: boolean,
 ): Promise<boolean> {
   return (
+    // In testing, gzip performs better than zstd on Windows.
+    process.platform !== "win32" &&
     tarSupportsZstd &&
     semver.gte(cliVersion, CODEQL_VERSION_ZSTD_BUNDLE) &&
     !!(await features.getValue(Feature.ZstdBundle))