-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run ML-powered query pack ~0.3.0
on v2.9.3+ of the CLI
#1087
Conversation
@henrymercer is this how we would like to start running Specifically, I've assumed in this PR that if the CLI is below 2.9.3, but above 2.8.4, we use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic looks right to me, however to merge it we'll need to do two things:
-
Compile the TypeScript files to JavaScript — there are instructions for that here: https://github.com/github/codeql-action/blob/main/CONTRIBUTING.md#development-and-testing. You should end up checking in a
src/util.ts
and correspondinglib/util.js
andlib/util.js.map
files. Let me know if you have any problems! -
Add some tests for this functionality in
config-utils.test.ts
to verify that the right pack gets loaded for 2.9.3. This commit shows how we did this for0.2.0
: e26813c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks generally sensible. And you'll also need to do what Henry suggests.
This PR is almost ready for another look, but one of the |
There is an You will need to change how the title is generated to ensure this is how it works. You can run the tests locally to ensure the titles are unique before pushing up a change. |
18563f4
to
602d5a3
Compare
Thanks for the help @aeisenberg! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, assuming all the tests pass.
04a23ec
to
a27dc4f
Compare
@henrymercer these two PR checks (here and here), involving a multi-language repo on mac, keep getting cancelled during the I restarted each check to see if it was a transient problem, but it happened again. Any ideas why this might be happening? |
I've raised the flaky tests internally. It seems that another rerun has sorted things with one of the jobs, so I've kicked off another run of the other job too. |
Thanks for looking into it @henrymercer and doing the reruns! |
This PR starts running the following versions of the ML-powered query pack:
~0.3.0
of the query pack on v2.9.3+ of the CLI~0.2.0
of the query pack on v2.8.4 <= CLI < v2.9.3~0.1.0
of the query pack on CLI < v2.8.4Merge / deployment checklist