-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the check-sarif action #1096
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeisenberg
force-pushed
the
aeisenberg/check-sarif-action
branch
11 times, most recently
from
June 14, 2022 18:46
d3b9427
to
11fe02e
Compare
Allows us to analyze and then check that certain queries were included in the analysis and others were not.
aeisenberg
force-pushed
the
aeisenberg/check-sarif-action
branch
from
June 14, 2022 18:55
11fe02e
to
bcb7fad
Compare
This change adds a `query-filters` property to the codeql-config file. This property is an array of `exclude`/`include` entries for a query suite. These filters are appended to the generated query suite files and used to filter queries after they are selected. A related change is that now, all pack references are run in a single query suite, which has the query filters appended to them.
|
henrymercer
reviewed
Jun 15, 2022
Also simplify some computations.
aeisenberg
force-pushed
the
aeisenberg/check-sarif-action
branch
from
June 15, 2022 23:06
1754357
to
4918636
Compare
henrymercer
approved these changes
Jun 15, 2022
Co-authored-by: Henry Mercer <[email protected]>
Removes duplicated yaml. Also add some better typings.
Add capability to filter queries
aeisenberg
force-pushed
the
aeisenberg/check-sarif-action
branch
from
June 16, 2022 00:53
25cbd7a
to
80ecdcd
Compare
@@ -0,0 +1,20 @@ | |||
name: Check SARIF |
Check failure
Code scanning / CodeQL
Inconsistent action input
Action [.github/check-sarif](1) and action [.github/query-filter-test](2) both declare input sarif-file, however their definitions are not identical. This may be confusing to users.
@@ -0,0 +1,52 @@ | |||
name: Query Filter Test |
Check failure
Code scanning / CodeQL
Inconsistent action input
Action [.github/query-filter-test](1) and action [init](2) both declare input tools, however their definitions are not identical. This may be confusing to users.
Action [.github/query-filter-test](1) and action [init](2) both declare input config-file, however their definitions are not identical. This may be confusing to users.
This was referenced Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows us to analyze and then check that certain queries were included
in the analysis and others were not.
This will be used in a future PR, but want to get this in first.
Merge / deployment checklist