Allow scans with packs for languages not being scanned #1116
+93
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/config-utils.ts
Outdated
| @@ -1168,7 +1168,8 @@ export function parsePacksFromConfig( | |||
| throw new Error(getPacksInvalid(configFile)); | |||
| } | |||
| if (!languages.includes(lang as Language)) { | |||
| throw new Error(getPacksRequireLanguage(lang, configFile)); | |||
| // This particular language is not being analyzed in this run. | |||
| continue; | |||
There was a problem hiding this comment.
This means that we won't fail on the pack with the wrong language, but we won't attempt to run the pack below either, right? A comment to that effect would be great.
aeisenberg
force-pushed
the
aeisenberg/multi-lang-packs
branch
2 times, most recently
from
6cc8292
to
4e14024
Compare
|
Currently failing on the nightly builds. These should be fixed by github/codeql#9667. I am currently building a nightly release that should contain the fix. |
Previously, we were being too strict about checking that a pack's language was being scanned. It was a failure if a pack language was specified for a language not being scanned.
aeisenberg
force-pushed
the
aeisenberg/multi-lang-packs
branch
from
4e14024
to
1653a84
Compare
|
@adityasharad can I get another look at this PR from you? I'd like to get this in the next release. |
adityasharad
approved these changes
Jun 24, 2022
This was referenced Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were being too strict about checking that a pack's
language was being scanned. It was a failure if a pack language
was specified for a language not being scanned.
Merge / deployment checklist