Disable python2 + poetry #1124
Merged
Disable python2 + poetry #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeisenberg
commented
Jun 24, 2022
cklin
approved these changes
Jun 24, 2022
aeisenberg
force-pushed
the
aeisenberg/poetry-python2
branch
from
ae5f4ec
to
934c034
Compare
This was referenced Jun 28, 2022
3 tasks
zendesk-ops-ci
pushed a commit
to zendesk/codeql-action
that referenced
this pull request
Aug 15, 2022
Just like we did for poetry and Python 2 in github#1124 From looking at changelogs, Python2 has not been supported in Pipenv since [v2021.11.5](https://pipenv.pypa.io/en/latest/changelog/#id149)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1122
Merge / deployment checklist
Confirm this change is backwards compatible with existing workflows.This change explicitly breaks compatibility.