-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for downloading packs from GHES #1221
Changes from 6 commits
c7bb894
0e98efa
1d92118
e9b47b1
b044362
abdf26c
7e086b2
bf97a6d
376fea6
4fa3e8b
5dcb9de
aa434aa
5974446
6085805
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -10,9 +10,35 @@ inputs: | |||||
description: The languages to be analysed | ||||||
required: false | ||||||
token: | ||||||
description: GitHub token to use for authenticating with this instance of GitHub. To download custom packs from multiple registries, use the registries input. | ||||||
default: ${{ github.token }} | ||||||
required: false | ||||||
registries: | ||||||
description: | | ||||||
A YAML string that defines the list of GitHub container registries to use for downloading packs. The string is in the following forma (the | is required on the first line): | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
registries: | | ||||||
- url: https://containers.GHEHOSTNAME1/v2/ | ||||||
packages: | ||||||
- my-company/* | ||||||
- my-company2/* | ||||||
token: ${{ secrets.GHEHOSTNAME1_TOKEN }} | ||||||
|
||||||
- url: https://ghcr.io/v2/ | ||||||
packages: */* | ||||||
token: ${{ secrets.GHCR_TOKEN }} | ||||||
|
||||||
The url property contains the url to the container registry you want to connect to. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
The packages property contains a single entry or a list of globs specifying packages that can be found in the container registry. Order is important. Earlier entries will match before later entries. | ||||||
|
||||||
The token property contains a connection token for this registry. | ||||||
|
||||||
If this input is missing, the `token` input is used for all pack downloads. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm surprised to read this — shouldn't we ensure that the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am not sure what you mean here. If the Would it be sufficient to say something like:
? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the clarification. I originally interpreted "the |
||||||
required: false | ||||||
matrix: | ||||||
default: ${{ toJson(matrix) }} | ||||||
required: false | ||||||
config-file: | ||||||
description: Path of the config file to use | ||||||
required: false | ||||||
|
@@ -32,7 +58,7 @@ inputs: | |||||
analyses, you must specify packs in the codeql-config.yml file. | ||||||
required: false | ||||||
external-repository-token: | ||||||
description: A token for fetching external config files and queries if they reside in a private repository. | ||||||
description: A token for fetching external config files and queries if they reside in a private repository in the same GitHub instance that is running this action. | ||||||
required: false | ||||||
setup-python-dependencies: | ||||||
description: Try to auto-install your python dependencies | ||||||
|
@@ -82,4 +108,4 @@ outputs: | |||||
runs: | ||||||
using: 'node16' | ||||||
main: '../lib/init-action.js' | ||||||
post: '../lib/init-action-post.js' | ||||||
post: '../lib/init-action-post.js' |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we mention the
registries
field here briefly?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this entry is in the wrong version. I'll change that, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also like to link to the documentation when it is available, but that won't be out for a while.