-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the CliConfigFileEnabled
feature flag
#1270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, there's a typo here
I'm going to add some unit tests. |
c72eb20
to
22bbeb8
Compare
Also, wire it up to the `useCodeScanningConfigInCli` function.
22bbeb8
to
e37b0d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 😸
Autogenerated JS files are not up to date, but otherwise ✅ |
5cc1af9
to
cab46c5
Compare
I think the failures are related to the Go extraction feature flag I just enabled. I un-enabled it again and they should work on re-run. |
Hmmm...required check |
I've seen this before. I think it's waiting on the upload jobs it depends on to finish, and then it will run. |
Well...I merged with main and updated all required checks. Hopefully, this is enough to fix things. Yours may have been an easier solution. |
Also, wire it up to the
useCodeScanningConfigInCli
function.Merge / deployment checklist