Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes deprecated set-output usage #1301

Merged
merged 3 commits into from
Oct 14, 2022
Merged

Conversation

aeisenberg
Copy link
Contributor

For more information see
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

This change bumps a bunch of the internal actions packages. Note that the only required version change is actions/core to 1.10.0. The others are not required, but seem like a reasonable idea.

It also changes all of the workflows that use set-output.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

For more information see
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

This change bumps a bunch of the internal actions packages. Note that
the only required version change is `actions/core` to 1.10.0. The others
are not required, but seem like a reasonable idea.

It also changes all of the workflows that use `set-output`.
@aeisenberg aeisenberg requested a review from a team as a code owner October 13, 2022 20:27
Copy link
Contributor

@adityasharad adityasharad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! Can you add a brief change note, highlighting the actions/core dependency change and that this addresses the deprecation warnings on use of set-output?

@aeisenberg
Copy link
Contributor Author

Sure

adityasharad
adityasharad previously approved these changes Oct 13, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Aditya Sharad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants