Delete the runner, part 2 #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We could move everything into `util`, but in some ways it is nice having a file dedicated to Actions related utilities.
henrymercer
force-pushed
the
henrymercer/delete-runner-part-2
branch
from
f885611
to
9df773d
Compare
aeisenberg
previously approved these changes
Nov 15, 2022
|
Addressed the merge conflicts from #1322. |
aeisenberg
approved these changes
Nov 15, 2022
This was referenced Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 2 of deleting the runner — see #1363 for part 1. Now that the runner is deleted, we can simplify a bunch of things in our code. This PR addresses most of the simplifications made possible, the others we should be able to address as drive-by improvements.
Merge / deployment checklist