Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI version field and prior release fields to defaults file #1463

Merged
merged 2 commits into from
Jan 6, 2023

Conversation

angelapwen
Copy link
Contributor

@angelapwen angelapwen commented Jan 6, 2023

In order to have more fine-grained control the CLI version present in the toolcache, we will be downloading the most recent 2 versions of the CLI bundle to the toolcache and selecting a version (based on feature flag rollout of the most recent version) for the Action.

The runner image script selects the bundle from the defaults file to determine which version of CodeQL to download. This change adds the bundle release prior to the most recent release under the field priorBundleVersion so that it is able to download both versions. We keep the bundleVersion field named the same to maintain backwards compatibility so that this change can be merged independently of the other changes in the Action.

The change also adds the CLI version for both the most recent release, and the prior release, so that the versions downloaded to the toolcache can be named appropriately (currently they are all prefixed with 0.0.0 rather than the actual x.y.z version of the CodeQL bundle.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@angelapwen angelapwen requested a review from a team as a code owner January 6, 2023 00:50
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth noting that the CLI version of each bundle is derivable by downloading the bundle release and running codeql version. However I think it make sense to include it here, as it will simplify the runner image creation scripts and other scripts processing this file.

@angelapwen angelapwen merged commit b4187d6 into github:main Jan 6, 2023
@angelapwen angelapwen deleted the add-version-default branch January 6, 2023 16:24
@angelapwen angelapwen mentioned this pull request Jan 6, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants