Fix a bug in cli config parsing #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the config specifies queries in external repositories and no other queries and cli config parsing is enabled, the analyze job is not able to find any queries to run and it fails. This PR fixes the problem. Also add some logging statements when writing a copy of the user config file.
|
Closing and re-opening with config parsing enabled in this repository. |
henrymercer
approved these changes
Jan 18, 2023
Comment on lines
+1454
to
+1457
| logger.info(`Writing augmented user configuration file to ${configLocation}`); | ||
| logger.startGroup("Augmented user configuration file contents"); | ||
| logger.info(yaml.dump(augmentedConfig)); | ||
| logger.endGroup(); |
There was a problem hiding this comment.
I think this makes sense as info while we're rolling out the flag, but let's consider making this debug afterwards.
This was referenced Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the config specifies queries in external repositories and no other queries and cli config parsing is enabled, the analyze job is not able to find any queries to run and it fails. This PR fixes the problem.
Also add some logging statements when writing a copy of the user config file.