Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CodeQL path from init Action in Windows Python dependencies PR checks #1502

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

henrymercer
Copy link
Contributor

This replicates what we do for other OSes, and makes the PR check stable to changes in the layout of the toolcache, such as #1475. I've also updated the workflow name to reflect the fact some of the tests run on Windows.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team January 23, 2023 13:02
@henrymercer henrymercer requested a review from a team as a code owner January 23, 2023 13:02
Copy link
Member

@RasmusWL RasmusWL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both changes looks good to me 👍

@henrymercer henrymercer merged commit 5794d96 into main Jan 23, 2023
@henrymercer henrymercer deleted the henrymercer/python-packages-use-path-from-action branch January 23, 2023 13:26
@github-actions github-actions bot mentioned this pull request Jan 26, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants